Merge pull request #212 from RitvikSardana/video-control

fix: show video controls when the editor is in edit mode
frappe · Nov 5, 2024 · d0ede35 · d0ede35
2 parents 2e14f0e + 8d0bc34
commit d0ede35
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/src/components/TextEditor/InsertVideo.vue b/src/components/TextEditor/InsertVideo.vue
@@ -44,10 +44,12 @@
       />
     </template>
     <template #actions>
-      <Button variant="solid" @click="addVideo(addVideoDialog.url)">
-        Insert Video
-      </Button>
-      <Button @click="reset">Cancel</Button>
+      <div class="flex gap-2">
+        <Button variant="solid" @click="addVideo(addVideoDialog.url)">
+          Insert Video
+        </Button>
+        <Button @click="reset">Cancel</Button>
+      </div>
     </template>
   </Dialog>
 </template>

diff --git a/src/components/TextEditor/video-extension.js b/src/components/TextEditor/video-extension.js
@@ -38,6 +38,7 @@ const Video = Node.create({
       const video = document.createElement('video')
       if (editor.isEditable) {
         video.className = 'pointer-events-none'
+        video.controls = true
       }
       video.src = node.attrs.src
       if (!editor.isEditable) {