Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): ticket: handle out of bounds (not found) #1417

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Aug 1, 2023

closes #1405

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (6453da4) 13.16% compared to head (1e08aaa) 13.20%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
+ Coverage   13.16%   13.20%   +0.03%     
==========================================
  Files          56       56              
  Lines        1967     1962       -5     
==========================================
  Hits          259      259              
+ Misses       1708     1703       -5     
Files Changed Coverage Δ
helpdesk/helpdesk/doctype/hd_ticket/api.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssiyad ssiyad merged commit f45b76e into frappe:main Aug 1, 2023
7 of 8 checks passed
@ssiyad ssiyad deleted the fix/api/handle_list_error_oob branch August 1, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve ticket non-existence error
1 participant