-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Over time feature #2314
base: develop
Are you sure you want to change the base?
feat: Over time feature #2314
Conversation
@iamejaaz Please add docs in todo. |
{ | ||
"default": "0", | ||
"fieldname": "actual_overtime_duration", | ||
"fieldtype": "Time", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Float
fieldtype would've been better and easier for calculations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid merge commits like these as long as there are no conflicts - 44c9c53 creates unnecessary noise and can even cause backport failures |
Hi team, can I get a review on this PR? |
TODO:
Overtime Type Doctype
Changes in Shift Type Doctype
Attendance Doctype changes
Overtime Slip
Salary slip