CLAP 1.1.9 #325
Merged
CLAP 1.1.9 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GUI extension: !floating tag
robbert-vdh
suggested changes
May 23, 2023
Co-authored-by: Robbert van der Helm <mail@robbertvanderhelm.nl>
Co-authored-by: Trinitou <106991375+Trinitou@users.noreply.github.com>
Fix C++ version checking on MSVC
Fix typo
Fix various typos
Initial take on undo support
Introduce incremental state
using the same wording as in tail extension to clarify details.
clarify latency is defined in samples
abique
requested review from
robbert-vdh,
baconpaul,
Bremmers and
defiantnerd
Bremmers
approved these changes
Oct 17, 2023
baconpaul
reviewed
Oct 17, 2023
Co-authored-by: Trinitou <106991375+Trinitou@users.noreply.github.com>
Clarify ambisonic enums
defiantnerd
approved these changes
Oct 19, 2023
| @@ -42,12 +42,16 @@ typedef struct clap_plugin_audio_ports_activation { | |||
| // It is only possible to activate and de-activate on the audio-thread if | |||
| // can_activate_while_processing() returns true. | |||
| // | |||
| // sample_size indicate if the host will provide 32 bit audio buffers or 64 bits one. | |||
| // Possible values are: 32, 64 or 0 if unspecified. | |||
There was a problem hiding this comment.
What is the reasoning behind 0 = unspecified?
There was a problem hiding this comment.
It is when this could dynamically change without deactivating the plugin, for example if there are multiple sources and a switch.
ABI (Application Binary Interface), can be a confusing term for people who stumble over it. What we want to achieve is to let people know that the interface is stable and backwards compatible.
README: Re-phrase the mentioning of ABI
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.