Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update undo draft #420

Merged
merged 7 commits into from
Sep 16, 2024
Merged

Update undo draft #420

merged 7 commits into from
Sep 16, 2024

Conversation

abique
Copy link
Contributor

@abique abique commented Sep 11, 2024

No description provided.

@tim-janik
Copy link
Contributor

Glancing over this draft, I have two questions:

  1. When undo/redo processing is left to the host, how does the host learn that a new undo step should be added to the undo history, in case a user makes a change purley through the plugin UI? Consider hosts that continuously display a list of recorded undo history (e.g. like gimp's "Undo History" tab).

  2. I am not sure the API allows the host to provide a fully linearized undo/redo history as described in TheGURQ. Do you have thoughts on that? https://github.com/zaboople/klonk/blob/master/TheGURQ.md

@abique
Copy link
Contributor Author

abique commented Sep 16, 2024

Glancing over this draft, I have two questions:

1. When undo/redo processing is left to the host, how does the host learn that a new undo step should be added to the undo history, in case a user makes a change purley through the plugin UI? Consider hosts that continuously display a list of recorded undo history (e.g. like gimp's "Undo History" tab).

The plugin calls host->begin_change() and host->change_made() or host->cancel_change().

2. I am not sure the API allows the host to provide a fully linearized undo/redo history as described in [TheGURQ](https://github.com/zaboople/klonk/blob/master/TheGURQ.md). Do you have thoughts on that? https://github.com/zaboople/klonk/blob/master/TheGURQ.md

It is fully linearized.

@abique abique merged commit 0b92b89 into free-audio:next Sep 16, 2024
4 checks passed
@abique abique deleted the undo branch September 16, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants