New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AUSF app, sbi, processor, consumer #29

Merged

ianchen0119 merged 16 commits into free5gc:main from TYuan0816:refactor/server

Jun 28, 2024

Contributor

TYuan0816 commented May 9, 2024

No description provided.

TYuan0816 added 4 commits

May 9, 2024 23:40


          refactor: sbi server

25daec5


          refactor: processor

35175b3


          refactor: consumer

5920ef6


          fix: linter error

4e792d1

andy89923 requested review from andy89923 and ianchen0119

May 25, 2024 15:37

andy89923 requested changes

View reviewed changes

Contributor

andy89923 left a comment

These two services must also be refactored even though we didn't implement them.

sorprotection
upuprotection

internal/sbi/processor/processor.go Outdated Show resolved Hide resolved

yccodr reviewed

View reviewed changes

internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved

pkg/service/init.go Outdated Show resolved Hide resolved

Contributor

ianchen0119 commented Jun 6, 2024

Hi @TYuan0816
Please revise your PR based on the review comments.

Thanks.

pf-lin reviewed

View reviewed changes

pkg/service/init.go Outdated Show resolved Hide resolved

pf-lin reviewed

View reviewed changes

pkg/service/init.go Outdated Show resolved Hide resolved

pf-lin reviewed

View reviewed changes

pkg/service/init.go Outdated Show resolved Hide resolved

pf-lin reviewed

View reviewed changes

pkg/service/init.go Outdated Show resolved Hide resolved

pf-lin reviewed

View reviewed changes

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

pf-lin reviewed

View reviewed changes

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

pf-lin reviewed

View reviewed changes

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

pf-lin reviewed

View reviewed changes

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

TYuan0816 added 3 commits

June 8, 2024 21:58


          refactor: refactor sorprotection and upuprotection

13a472a


          fix: remove unused code


          fix: align naming convention

44f7cfd

Contributor Author

TYuan0816 commented Jun 9, 2024

Hi everyone. Thanks for your comments. I have made the corrections you suggested. Please help me check it. Thank you.

andy89923 self-requested a review

June 10, 2024 09:09

andy89923 reviewed

View reviewed changes

Contributor

andy89923 left a comment •

edited

Loading

~~The others LGTM!~~

You could resolve the conservation you had solved.

internal/sbi/sorprotection/routers.go Show resolved Hide resolved

internal/sbi/upuprotection/routers.go Show resolved Hide resolved

andy89923 reviewed

View reviewed changes

internal/sbi/consumer/consumer.go Outdated Show resolved Hide resolved

internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

andy89923 reviewed

View reviewed changes

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

TYuan0816 added 4 commits

June 17, 2024 03:17


          fix: add sorprotection and upuprotection routes

c6ace2b


          refactor: add routes to newRouter

de42b01


          fix: assign consumer

7f58f5f


          fix: add header

7ec201b

TYuan0816 requested a review from andy89923

June 17, 2024 15:29

andy89923 reviewed

View reviewed changes

internal/sbi/api_sorprotection.go Outdated Show resolved Hide resolved

internal/sbi/api_upuprotection.go Outdated Show resolved Hide resolved

internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved

internal/sbi/consumer/nrf_service.go Outdated Show resolved Hide resolved

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

internal/sbi/consumer/consumer.go Outdated Show resolved Hide resolved

andy89923 and others added 3 commits

June 21, 2024 05:08


          fix: terminate procedure and unecessary defer

ca00f22


          refactor: add UDM service consumer

60a2dde


          fix: remove GetConsumer() and add http.NotImplement

4fdd4bd

andy89923 approved these changes

View reviewed changes

andy89923 requested changes

View reviewed changes

Contributor

andy89923 left a comment

Please follow others NFs Processor.
Pass gin context and handle response.

andy89923 reviewed

View reviewed changes

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

andy89923 reviewed

View reviewed changes

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

pf-lin reviewed

View reviewed changes

internal/sbi/processor/ue_authentication.go Outdated Show resolved Hide resolved

ianchen0119 approved these changes

View reviewed changes

Contributor

ianchen0119 left a comment •

edited

Loading

Please update the PR based on the previous comments.
Overall, it is LGTM.

TYuan0816 and others added 2 commits

June 28, 2024 01:24


          fix: refactor processor

ec36f63


          fix: coding style and remove unused code

d333b08

andy89923 approved these changes

View reviewed changes

Contributor

andy89923 left a comment

LGTM

ianchen0119 merged commit 842217c into free5gc:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet