fix: use type assertion to judge deregister error

free5gc · Aug 9, 2024 · bc74a3e · bc74a3e
1 parent b3cf85f
commit bc74a3e
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/internal/sbi/consumer/nrf_service.go b/internal/sbi/consumer/nrf_service.go
@@ -146,13 +146,23 @@ func (ns *NrfService) SendDeregisterNFInstance() (problemDetails *models.Problem
 	}
 	_, deregisterErr := client.NFInstanceIDDocumentApi.DeregisterNFInstance(ctx, deregisterReq)
 	if deregisterErr != nil {
-		if apiErr, ok := deregisterErr.(openapi.GenericOpenAPIError); ok {
-			pd = apiErr.Model().(*models.ProblemDetails)
-			return pd, deregisterErr
+		switch apiErr := deregisterErr.(type) {
+		case openapi.GenericOpenAPIError:
+			switch errModel := apiErr.Model().(type) {
+			case NFManagement.DeregisterNFInstanceError:
+				problemDetails = &errModel.ProblemDetails
+				return problemDetails, nil
+			case error:
+				problemDetails = openapi.ProblemDetailsSystemFailure(errModel.Error())
+				return problemDetails, nil
+			}
+		case error:
+			problemDetails = openapi.ProblemDetailsSystemFailure(apiErr.Error())
+			return problemDetails, nil
 		}
 		return nil, deregisterErr
 	}
-	return problemDetails, err
+	return nil, nil
 }
 
 func (ns *NrfService) SendSearchNFInstances(nrfUri string,