Skip to content

chore: move storybook config files to use typescript#374

Merged
huyenltnguyen merged 3 commits intofreeCodeCamp:mainfrom
shootermv:convert-storybook-config-files-to-ts
Feb 11, 2025
Merged

chore: move storybook config files to use typescript#374
huyenltnguyen merged 3 commits intofreeCodeCamp:mainfrom
shootermv:convert-storybook-config-files-to-ts

Conversation

@shootermv
Copy link
Contributor

@shootermv shootermv commented Oct 13, 2024

Checklist:

Closes #369

@shootermv shootermv requested a review from a team October 13, 2024 08:45
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 5ed3484 to 594ced6 Compare October 20, 2024 14:07
huyenltnguyen
huyenltnguyen reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@huyenltnguyen huyenltnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

I'm afraid renaming the files is not enough. I pulled the branch down and got some TS errors in main.ts, manager.ts, and theme.ts.

Those TS errors should be reported when the typecheck command runs, but they currently aren't. So there should be some changes to the tsconfig file as well.

@huyenltnguyen huyenltnguyen added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Oct 24, 2024
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch 2 times, most recently from c6b794f to cba6c5a Compare October 24, 2024 18:00
@shootermv
Copy link
Contributor Author

shootermv commented Oct 28, 2024

I added some missing packages Which seem to resolve ts errors (hope u will have time to review)

@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from cba6c5a to f63d2c0 Compare November 8, 2024 11:35
@shootermv
Copy link
Contributor Author

shootermv commented Nov 8, 2024

updated the PR.. hope this time is good

@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from f63d2c0 to 50e4c34 Compare November 8, 2024 12:24
@shootermv
Copy link
Contributor Author

shootermv commented Nov 18, 2024 •
edited
Loading

Is something wrong with this PR , which need update?

@majestic-owl448 majestic-owl448 added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Nov 18, 2024
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 50e4c34 to 9313116 Compare November 18, 2024 11:10
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 9313116 to 471aa4f Compare November 25, 2024 16:15
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 471aa4f to c7013d9 Compare January 6, 2025 12:47
@raisedadead raisedadead removed the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Jan 6, 2025
@shootermv
Copy link
Contributor Author

shootermv commented Jan 10, 2025

What is the status of the pr now?

@majestic-owl448
Copy link

majestic-owl448 commented Jan 10, 2025

you have merge conflicts

@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from c7013d9 to 5a441d4 Compare January 10, 2025 10:13
@shootermv shootermv force-pushed the convert-storybook-config-files-to-ts branch from 5a441d4 to b6dcbc4 Compare January 10, 2025 10:36
@shootermv
Copy link
Contributor Author

shootermv commented Jan 10, 2025

conflicts fixed

@raisedadead
Copy link
Member

raisedadead commented Jan 10, 2025

Thanks for your patience – We have requested @huyenltnguyen to take another look at this. We will get back to you when we are able.

@shootermv
Copy link
Contributor Author

shootermv commented Jan 10, 2025

Thanks

@shootermv
Copy link
Contributor Author

shootermv commented Feb 5, 2025

looks like this Pr is takes a long time to review...

@majestic-owl448 majestic-owl448 added status: merge conflict To be applied to PR's that have a merge conflict and need updating and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels Feb 11, 2025
@majestic-owl448
Copy link

majestic-owl448 commented Feb 11, 2025

you have merge conflicts

@ojeytonwilliams
Copy link
Contributor

ojeytonwilliams commented Feb 11, 2025

There's always going to merge conflicts on this PR since it touches the lock file. I recommend waiting until the PR has been approved before fixing them.

@huyenltnguyen huyenltnguyen force-pushed the convert-storybook-config-files-to-ts branch from f64af2a to 5731b7d Compare February 11, 2025 18:37
@huyenltnguyen huyenltnguyen merged commit c350b0f into freeCodeCamp:main Feb 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huyenltnguyen huyenltnguyen huyenltnguyen approved these changes

Assignees

No one assigned

Labels

status: merge conflict To be applied to PR's that have a merge conflict and need updating

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Convert Storybook config files to TypeScript

5 participants

@shootermv @majestic-owl448 @raisedadead @ojeytonwilliams @huyenltnguyen