Skip to content

iio-sensor-proxy: init at 3.6 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JohnAZoidberg
Copy link
Contributor

Preparation for Framework 12 (Convertible) g-sensor to let the screen rotate.

monitor-sensor can run, but we don't have any kernel interfaces for sensors in FreeBSD yet.

@JohnAZoidberg
Copy link
Contributor Author

Draft because it's not useful yet, but I wouldn't mind if it got merged already.
We can enable kernel interfaces and upgrade this package later.

@lwhsu lwhsu self-assigned this Mar 9, 2025
@lwhsu
Copy link
Member

lwhsu commented Mar 9, 2025

Draft because it's not useful yet, but I wouldn't mind if it got merged already. We can enable kernel interfaces and upgrade this package later.

Yeah, I think it's fine to have things prepared. Or at least letting it ready and people can test with the kernel changes.

I've done some adjustments to the Makefile to follow the ports' standard:

https://gist.github.com/lwhsu/fd9f05f055db2f13765fa2fea7e1a371

Also, it seems not buildable in the poudriere for now:

https://gist.github.com/lwhsu/759f4f824169525cb46640d951386843

monitor-sensor can run, but we don't have any
kernel interfaces for sensors in FreeBSD yet.

Signed-off-by: Daniel Schaefer <dhs@frame.work>
@JohnAZoidberg
Copy link
Contributor Author

I've done some adjustments to the Makefile to follow the ports' standard:

Thanks, I applied your formatting.

@lwhsu
Copy link
Member

lwhsu commented Mar 10, 2025

I got this in poudriere test build:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: disabled/80-iio-sensor-proxy.rules
Error: Orphaned: disabled/iio-sensor-proxy.service
Error: Orphaned: libexec/iio-sensor-proxy
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: usr/lib/iio-sensor-proxy
Error: Missing: usr/lib/udev/rules.d/80-iio-sensor-proxy.rules
===> Error: Plist issues found.

The first part means that this port installs these files but we don't have them listed in pkg-plist, I'm not sure if those files under disabled/ is really needed, though.

The second part mean that we have them in pkg-plist but not installed, it seems iio-sensor-proxy is actually be in libexec/ (and that looks reasonable)

What I'm not sure is that should we do something to teach it install 80-iio-sensor-proxy.rules to the right place we want?

libgudev-1.0.so:devel/libgudev \
libpolkit-gobject-1.so:sysutils/polkit

USES= pkgconfig meson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USES values should be sorted.

@@ -0,0 +1,5 @@
bin/monitor-sensor
usr/lib/iio-sensor-proxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks suspicious. It feels like we should have MESON_ARGS= -Dlibexecdir=${PREFIX}/libexec in the Makefile to make this file go into a correct dir.

@@ -0,0 +1,5 @@
bin/monitor-sensor
usr/lib/iio-sensor-proxy
usr/lib/udev/rules.d/80-iio-sensor-proxy.rules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this file is still installed despite the -Dudevrulesdir=disabled arg, then we need to prepend @comment there to prevent it from being packaged into the final package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants