Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Migrate dependency management to poetry #41

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Migrate dependency management to poetry #41

merged 1 commit into from
Nov 7, 2023

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Nov 3, 2023

Switch dependency management to use poetry, which is much nicer than pip-tools. This is largely based off of
freedomofpress/securedrop-proxy#122 and applies the same changes to the Makefile and CI.


note: this will fail CI until freedomofpress/securedrop-builder#472 is merged.

Switch dependency management to use poetry, which is much nicer than
pip-tools. This is largely based off of
<freedomofpress/securedrop-proxy#122> and
applies the same changes to the Makefile and CI.
@rocodes rocodes self-assigned this Nov 7, 2023
Makefile Show resolved Hide resolved
@legoktm
Copy link
Member Author

legoktm commented Nov 7, 2023

So for test plan, I think just verifying all the various make test, etc. commands you run locally during development work and then also doing a package build works.

I think going through the whole test plan in freedomofpress/securedrop-builder#467 is overkill largely because it was testing all the changes in -builder, which have already been reviewd.

@rocodes
Copy link
Contributor

rocodes commented Nov 7, 2023

So far so good :)

  • visual review
  • poetry install succecssful, updated make targets successful
  • building a package from tip of sd-builder works great
    I just kicked CI too so we should be seeing lots of 💚

edit: lastly

  • adding a dependency in pyproject.toml and running poetry update updates build reqs and poetry.lock, and hashes match the same dependency being added in build-requirements.in and updating dependencies via pip-compile

Copy link
Contributor

@rocodes rocodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making this happen :) (Gonna hold off on merge til end of the day in case you want to sneak the poetry version update in, and we should probably update the dev docs and/or the sdw wiki once some more of these changes land, but 🥳)

@legoktm
Copy link
Member Author

legoktm commented Nov 7, 2023

(lack of docs issue is freedomofpress/securedrop-dev-docs#103)

@rocodes rocodes merged commit 29810a7 into main Nov 7, 2023
2 checks passed
@legoktm legoktm deleted the only-poetry branch November 13, 2023 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants