-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 1.0.2 #1246
Merged
Merged
Backport 1.0.2 #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d9a984a)
rocodes
previously approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on visual review, pending CI.
(cherry picked from commit 4b97977)
Based on the keyring tests in securedrop-client, add a test for the PGP key embedded in apt_freedom_press.sources and the key for dom0. It verifies only one key is present, it has the fingerprint we expect, it has a 2027 expiry, and the expiry is more than 6 months from now. (cherry picked from commit 8ac30ec)
2c52a7f
to
6f80e6f
Compare
I made a mistake when cherry-picking the sd-log patch, there was a new features.set stanza later on in the file which overwrote the one we added to set the epoch. Should be fixed now! |
6f80e6f
to
fed3ab6
Compare
(cherry picked from commit dae9bb2)
fed3ab6
to
46d18ff
Compare
Merging and tracking CI issue separately in #1247 |
rocodes
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Cherry-pick fixes from the 1.0.2 release.
Testing