Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manage py to use app context #6423

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

nahara7
Copy link

@nahara7 nahara7 commented May 3, 2022

Status

Work in progress: Raises correct exceptions, fails test suite.

Description of Changes

Addresses #6188.

Exceptions for invalid usernames were not being raised. Instead, there was python traceback where ngettext was used.
Adds an application context before exception calls.

Testing

From the developer environment

  • exec into Securedrop container
  • ./manage.py add-admin # Try any 2-letter username
  • ./manage.py add-journalist # Try any 2-letter username

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

@eloquence
Copy link
Member

Hi @nahara7, just touching base - are you still interested in working further on this?

@eloquence
Copy link
Member

Hi @nahara7, just checking in if you'd like to continue to work on this, or if you'd prefer if someone else pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants