Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ruff, remove black #7233

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Upgrade ruff, remove black #7233

merged 3 commits into from
Oct 7, 2024

Commits on Sep 19, 2024

  1. Upgrade ruff, remove black 

    Upgrade ruff to the latest version so we can use it for formatting and
native editor integration. While we're at it, introduce the standard
`make fix` target
(<freedomofpress/securedrop-tooling#11>).

We can remove `--show-source` too now that it's the default.

Actually fixing new issues will happen in follow-ups to make this change
easier to review.

Fixes #7226.
    @legoktm
    legoktm committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6770d12 View commit details
    Browse the repository at this point in the history

  2. Apply ruff format . 

    This is all automated except test_manage.py was manually fixed to remove
extraneous commas that ruff tried to turn into tuples.
    @legoktm
    legoktm committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fddfa08 View commit details
    Browse the repository at this point in the history

  3. Fix most errors spotted by ruff 

    About half of these fixes were automatic, the rest I did by hand.

I skipped removing % formatting from pretty_bad_protocol since there
were like a hundred of them and it wasn't really worth it.
    @legoktm
    legoktm committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    7ad8828 View commit details
    Browse the repository at this point in the history