Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): Include additional information in Docket Alarms and Docket Notes #4447

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elisa-a-v
Copy link

This PR adds a column for the docket number both in docket alerts and in docket notes. It also adds a column for the docket's date filed in the alarm table, and a column for the docket's court in the docket notes.

The mobile version of all tables is currently awkward and hard to navigate, but I would suggest replacing the <table> and use flexbox instead, which I'm not sure is worth it at the moment.

Docket Alerts Desktop

image

Docket Alerts Mobile

alerts

Docket Alarms Desktop

image

Docket Alarms Mobile

notes

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@ERosendo ERosendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elisa-a-v Thanks for the PR! I reviewed the changes and they look great.

@mlissner I've been experimenting with the new information in the table and noticed that we're currently using the short_name from the court model. While this works, I found that sometimes the short_name can contain a few words, which might lead to cluttered templates due to the limited table space.

As an alternative, I think we can consider using the value of the citation_string field. This field provides a cleaner and more concise representation.

Here's a visual comparison:

Using short_name:

image

Using citation_string:

image

Let me know what you think! Happy to discuss this further.

@ERosendo ERosendo linked an issue Sep 17, 2024 that may be closed by this pull request
@mlissner
Copy link
Member

Makes sense to me, thanks Eduardo. Elisa, how are things coming with the more responsive version? (Feel free to email too.)

@elisa-a-v
Copy link
Author

elisa-a-v commented Sep 17, 2024

@mlissner I'm finishing up, it looks like this:

Docket alerts:

docker alerts

Docket notes:

docket notes

Opinion notes:

opinion notes

I'm wondering in the case of search alerts if we shouldn't switch the first two columns so that the collapsed list is a bit more descriptive? now it would look like this:
Screenshot from 2024-09-17 18-57-35
but maybe this would be better?
Screenshot from 2024-09-17 18-58-02

I created a separate PR for the responsive version, do I keep it that way?

@mlissner
Copy link
Member

Great! The separate PR is fine. Just let me know when it's ready to go and we'll give it a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add more columns to the Profile > Docket Alerts page
5 participants