Permit to provide custom CPPFLAGS_FOR_BUILD + propagate #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context of cross compilation the CPPFLAGS for the target might be different than the one for build tools. Permit to provide custom CPPFLAGS_FOR_BUILD value to handle this scenario. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
On building build tools, only CC_FOR_BUILD is used with CPPFLAGS_FOR_BUILD never actually passed. This was probably an oversight when CPPFLAGS_FOR_BUILD was introduced. This is especially needed on cross compilation where the header are placed on a standard location. To address this case, and make building build tool more robust, actually pass the CPPFLAGS_FOR_BUILD for each tool. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of cross compilation the CPPFLAGS for the target might be
different than the one for build tools.
Permit to provide custom CPPFLAGS_FOR_BUILD value to handle this
scenario.
On building build tools, only CC_FOR_BUILD is used with
CPPFLAGS_FOR_BUILD never actually passed. This was probably an oversight
when CPPFLAGS_FOR_BUILD was introduced.
This is especially needed on cross compilation where the header are
placed on a standard location.
To address this case, and make building build tool more robust, actually
pass the CPPFLAGS_FOR_BUILD for each tool.