Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar #150

Merged
merged 29 commits into from
Sep 7, 2024
Merged

Calendar #150

merged 29 commits into from
Sep 7, 2024

Conversation

noxilixon
Copy link
Contributor

@noxilixon noxilixon commented Apr 21, 2024

My solution is that we generate ical feeds with hugo that are consumed and displayed by a js calendar. So we have a nice overview on the website and people can subscribe to the feed iif they want. New events are added like other content with a simple md file.

  • Add recurring events functionality in ical
  • style the events page
  • create englisch version of events page
  • Manage JS dependencies
  • Display recurring events in words
  • Fix linting
  • Separate feeds for community, installation and external events
  • Write Readme

This resolves #133

@noxilixon
Copy link
Contributor Author

noxilixon commented Aug 20, 2024

@noxilixon noxilixon force-pushed the calendar branch 4 times, most recently from a002ebf to f1981bf Compare August 28, 2024 02:28
@noxilixon
Copy link
Contributor Author

I will change the event box color, so that it fulfills the accessibility criteria. Do you have other feedback on look/feel and features?

@noxilixon noxilixon marked this pull request as ready for review August 28, 2024 12:32
@noxilixon noxilixon requested a review from Noki August 28, 2024 12:32
@noxilixon
Copy link
Contributor Author

Also I would squash the commits before merging.

@Noki
Copy link
Member

Noki commented Aug 28, 2024

the preview URL is just showing a 404.

@noxilixon
Copy link
Contributor Author

the preview URL is just showing a 404.

Ah sorry, forgot about that, i fixed the link

@Noki
Copy link
Member

Noki commented Aug 28, 2024

The line length is to high if you click an event. Should be reduced to the same width as the normal layout.
The german page is in english (today, day names, time format) - can we change that?
I would also like to see at least one other event in the calender / feed.
In addition I find it kind of irritating that event names get shortened in the calendar.

@noxilixon
Copy link
Contributor Author

I used rrules to define recurring events, because this is the standard in ical. I would keep it that way. Then I used the library rrules to transform those rules into natural language. Works perfectly 😄 ... but only for englisch 😞. The library has issues with translations. There is no good solution for that right now. I tried some of the solutions mentioned in the issue, but without a result that is acceptable "jedes Monat auf dem NaN Mittwoch" 😆. I introduced an additional variable to create the text manually.

@noxilixon noxilixon marked this pull request as ready for review September 6, 2024 23:51
@noxilixon noxilixon requested review from Noki and removed request for Noki September 6, 2024 23:51
Copy link
Member

@Noki Noki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Desktop I get a vertical scroll bar that breaks the layout:

image

From what I can see the calendar has a fixed limited height. This will be even worse with more events in different weeks of the same months or more events at the same day. Maybe add some more data for testing... ;-)

Copy link
Member

@Noki Noki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now. squash this into a single commit and then feel free to merge.

@noxilixon noxilixon merged commit a321731 into main Sep 7, 2024
9 checks passed
@noxilixon noxilixon deleted the calendar branch September 7, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar functionality
2 participants