Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escape in regular expression #320

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Fix escape in regular expression #320

merged 1 commit into from
Feb 23, 2024

Conversation

sth
Copy link
Contributor

@sth sth commented Feb 19, 2024

The string used to create the regular expression should contain literal backslashes, so they need to be escaped. Python 12 warns about it:

hg-fast-export.py:231: SyntaxWarning: invalid escape sequence '\.'

frej
frej approved these changes Feb 22, 2024
View reviewed changes
Copy link
Owner

@frej frej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@frej frej merged commit 997e8e1 into frej:master Feb 23, 2024
4 checks passed
@frej
Copy link
Owner

frej commented Feb 23, 2024

Thank you for your contribution @sth.

@sth sth deleted the regex-escape branch February 23, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frej frej frej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sth @frej