Setup new deployment and pr preview deployments #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
force-pushed
the
ci/pr-deployments
branch
from
c489509 to
b4a4bcd
Compare
|
🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content. Preview URL: https://www.frequency.xyz/_pr/21/ |
wilwade
force-pushed
the
ci/pr-deployments
branch
from
c2486bd to
2ce0969
Compare
claireclark1
reviewed
Oct 2, 2024
| - name: Upload artifact | ||
| uses: actions/upload-pages-artifact@v3 | ||
| - name: Deploy to GitHub Pages | ||
| uses: JamesIves/github-pages-deploy-action@881db5376404c5c8d621010bcbec0310b58d5e29 |
There was a problem hiding this comment.
JamesIves is the sort of "standard" old way to deploy github pages. We have the commit sha there instead of a version as we allowlist non-github actions.
claireclark1
reviewed
Oct 2, 2024
| - name: Install Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 |
There was a problem hiding this comment.
what's the difference between say this is "20.x"?
claireclark1
approved these changes
Oct 2, 2024
shannonwells
pushed a commit
that referenced
this pull request
Oct 25, 2024
closes #13 ## Changes - Added footer content - Added layout styling so that the footer is always at the bottom. ## Demo <img width="1266" alt="Screenshot 2024-02-13 at 8 08 17 PM" src="https://github.com/AmplicaLabs/frequency-xyz/assets/43625033/2b414d5b-394c-4614-99f9-8caa4c5cac92"> <img width="431" alt="Screenshot 2024-02-13 at 8 08 11 PM" src="https://github.com/AmplicaLabs/frequency-xyz/assets/43625033/9e4f6f97-a52e-423e-8d33-c95c904c9405"> --------- Co-authored-by: Claire Olmstead <olmsteadclaire@gmail.com> Co-authored-by: Wil Wade <wil.wade@amplica.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a non-technical (or technical) reviewer of site changes, I want to see the site running so that I can see how it actually works.
Screenshot(s)
Type of change
How to Test?
Please describe how to test that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Checklist: