Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37 update theme with the one from the style guide #38

Merged

Conversation

claireolmstead
Copy link
Contributor

@claireolmstead claireolmstead commented Oct 28, 2024

Description

Update theme to use the styleguide.

Type of change

  • New Feature

How to Test?

Pull branch and see that styles look the same and are not broken in any screen size.

  1. Pull and run locally
  2. See that css is coming through as well as the theme. Best examples are the underline on hover in the nav (showing css) and the colors properly coming through (tailwind config)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code & PR, particularly in hard-to-understand areas
  • I have checked at all the breakpoints to make sure it works on all screen sizes

@claireolmstead claireolmstead linked an issue Oct 28, 2024 that may be closed by this pull request
1 task
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/38/
Commit: cb38c24

@@ -1,5 +1,6 @@
import '../style/app.css';

import * as styles from '@frequency-chain/style-guide';
console.log(styles);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this might be some leftover from debugging?

.idea/.gitignore Outdated Show resolved Hide resolved
@@ -5,7 +5,7 @@
export let linkedinUrl: string;
</script>

<div class="max-w-[100px] sm:text-indigo lg:text-cream">
<div class="max-w-[100px] sm:text-brightBlue lg:text-cream">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same hex, new name

@@ -5,7 +5,7 @@
</script>

<div class="w-full max-w-[425px] pb-[80px] sm:pt-[80px] lg:pl-[140px] lg:pt-6">
<h3 class="text-base font-semibold">Join the Digital Revolution</h3>
<h3 class="text-normal font-semibold">Join the Digital Revolution</h3>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new name

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/38/
Commit: c6523d2

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/38/
Commit: bc5c2c5

Copy link
Contributor

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great!

@claireolmstead claireolmstead merged commit d70c4f5 into main Oct 28, 2024
7 checks passed
@claireolmstead claireolmstead deleted the 37-update-theme-with-the-one-from-the-style-guide branch October 28, 2024 23:04
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update theme with the one from the style guide
2 participants