Landing page #44

saraswatpuneet · 2024-10-30T16:15:45Z

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Closes Top section Image & “Build with Frequency” #31

Screenshot(s)

Including screenshots helps reviewers know what to expect.

Desktop

Mobile

Type of change

Please delete options that are not relevant.

New Feature

How to Test?

Please describe how to test that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

git clone the repository
cd frequency-xyz && npm i
npm run dev then got to http://localhost:3000/docs

Checklist:

I have performed a self-review of my code
I have commented my code & PR, particularly in hard-to-understand areas
I have checked at all the breakpoints to make sure it works on all screen sizes

github-actions · 2024-10-30T16:16:20Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: a0da65c

github-actions · 2024-10-30T16:18:28Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: 8bcf717

github-actions · 2024-10-30T20:32:40Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: 609a904

github-actions · 2024-10-30T20:35:08Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: fdbfb2a

github-actions · 2024-10-30T20:37:40Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: d4eafd4

github-actions · 2024-10-30T21:35:29Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: fdceef0

github-actions · 2024-10-30T21:37:10Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: fd68822

src/components/Sections/SectionDefaultWave.svelte

shannonwells · 2024-10-30T21:46:35Z

Not sure if you meant for this to be reviewed yet, but it does have a lot of issues below 1300px and below 900px width

github-actions · 2024-10-31T13:40:29Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: 7a7a9cd

github-actions · 2024-10-31T14:39:53Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: af9d971

github-actions · 2024-10-31T14:43:09Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: 065c0eb

github-actions · 2024-10-31T18:57:13Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: a9d47d6

src/routes/docs/components/DocsBody.svelte

JoeCap08055

Couple of typos in the content, but otherwise looks good!

Co-authored-by: Joe Caputo <joseph.caputo@projectliberty.io>

github-actions · 2024-10-31T19:18:56Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: c092222

github-actions · 2024-10-31T19:19:31Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: 5a5b57a

wilwade · 2024-10-31T19:30:22Z

src/routes/docs/+page.svelte

+<div class="min-h-[calc(100vh-100px)]">
+  <div class="relative lg:max-w-[100vw] xl:max-w-page">
+    <div class="absolute top-0 z-50 w-full"><Header {logoHex} {navColor} bind:section /></div>
+    <div class={`relative w-[100vw] min-w-full sm:pt-[80px] lg:pt-[140px] vertical-lg:w-[100%]`}>
+      <DocsBody />
+    </div>
+  </div>
+</div>


I think you can get away with leaving src/routes/docs/+layout.svelte alone and just doing this:

Suggested change

<div class="min-h-[calc(100vh-100px)]">

<div class="relative lg:max-w-[100vw] xl:max-w-page">

<div class="absolute top-0 z-50 w-full"><Header {logoHex} {navColor} bind:section /></div>

<div class={`relative w-[100vw] min-w-full sm:pt-[80px] lg:pt-[140px] vertical-lg:w-[100%]`}>

<DocsBody />

</div>

</div>

</div>

<div>

<DocsBody />

</div>

Then you can also remove all the other section, color, and such.

I cannot get away with all, it then does not align with landing page, plus header is needed. I remove an outer class which had no effect

You can reset src/routes/docs/+layout.svelte and have the header in there right?

github-actions · 2024-10-31T19:39:22Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: cb1d975

github-actions · 2024-10-31T19:42:41Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: e78c020

github-actions · 2024-10-31T20:11:40Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: 16cf871

github-actions · 2024-10-31T21:00:39Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: fad1177

github-actions · 2024-10-31T21:14:42Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: a524569

github-actions · 2024-10-31T21:20:12Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: fb5f619

github-actions · 2024-10-31T21:22:17Z

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/44/
Commit: ac49948

# Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. - Closes #31 ## Screenshot(s) Including screenshots helps reviewers know what to expect. ### Desktop ![image](https://github.com/user-attachments/assets/30fa5aac-8dcb-4867-bfd0-e87abfabe1b9) ### Mobile ![image](https://github.com/user-attachments/assets/1b200ef1-c584-4a0b-8939-41ef9af294b5) ## Type of change Please delete options that are not relevant. - [x] New Feature # How to Test? Please describe how to test that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration 1. git clone the repository 2. `cd frequency-xyz && npm i` 3. `npm run dev` then got to `http://localhost:3000/docs` # Checklist: - [x] I have performed a self-review of my code - [ ] I have commented my code & PR, particularly in hard-to-understand areas - [ ] I have checked at all the breakpoints to make sure it works on all screen sizes --------- Co-authored-by: Joe Caputo <joseph.caputo@projectliberty.io>

saraswatpuneet added 2 commits October 30, 2024 10:23

base work

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

01e0bb8

set top page with placeholder image

c47af4e

cleanup

bc56c76

saraswatpuneet added 4 commits October 30, 2024 13:52

align with about page

cb93f0f

correction

8ae7fbb

styling

480a619

Merge branch 'developer-portal' into landing_page

faa9448

lint

4cdc273

lint

f485a3a

saraswatpuneet marked this pull request as ready for review October 30, 2024 20:39

addd placeholder section image

a7cdc4e

lint

6a50ee1

saraswatpuneet requested review from claireclark1 and wilwade October 30, 2024 21:36

saraswatpuneet commented Oct 30, 2024

View reviewed changes

src/components/Sections/SectionDefaultWave.svelte Outdated Show resolved Hide resolved

improve image placeholder

213d001

remove sections nesting and contains docs stuff in docs

3bed3f4

remove unused style

eae3367

remove image from mobile view

ee78267

JoeCap08055 reviewed Oct 31, 2024

View reviewed changes

src/routes/docs/components/DocsBody.svelte Outdated Show resolved Hide resolved

JoeCap08055 reviewed Oct 31, 2024

View reviewed changes

src/routes/docs/components/DocsBody.svelte Outdated Show resolved Hide resolved

JoeCap08055 requested changes Oct 31, 2024

View reviewed changes

saraswatpuneet and others added 2 commits October 31, 2024 14:18

Update src/routes/docs/components/DocsBody.svelte

f1af4e4

Co-authored-by: Joe Caputo <joseph.caputo@projectliberty.io>

Update src/routes/docs/components/DocsBody.svelte

a816e40

Co-authored-by: Joe Caputo <joseph.caputo@projectliberty.io>

JoeCap08055 approved these changes Oct 31, 2024

View reviewed changes

wilwade requested changes Oct 31, 2024

View reviewed changes

remove parts

4764972

remove outer scope

7d161ec

set page layout

90aa32e

cleanups for cleaner less wavy layout

cd28d9e

align top down

fc79ea8

render at laptopsize

f580dd5

rename

9446ab0

wilwade approved these changes Oct 31, 2024

View reviewed changes

saraswatpuneet merged commit 283af5c into developer-portal Oct 31, 2024
5 checks passed

saraswatpuneet deleted the landing_page branch October 31, 2024 22:07

github-actions bot pushed a commit that referenced this pull request Oct 31, 2024

Remove PR preview for #44

0e32144

wilwade mentioned this pull request Nov 1, 2024

Top section Image & “Build with Frequency” #31

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Landing page #44

Landing page #44

saraswatpuneet commented Oct 30, 2024 •

edited

Loading

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

shannonwells commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

JoeCap08055 left a comment

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

wilwade Oct 31, 2024

saraswatpuneet Oct 31, 2024

wilwade Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

Landing page #44

Landing page #44

Conversation

saraswatpuneet commented Oct 30, 2024 • edited Loading

Description

Screenshot(s)

Desktop

Mobile

Type of change

How to Test?

Checklist:

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

github-actions bot commented Oct 30, 2024

shannonwells commented Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

JoeCap08055 left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

wilwade Oct 31, 2024

Choose a reason for hiding this comment

saraswatpuneet Oct 31, 2024

Choose a reason for hiding this comment

wilwade Oct 31, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

saraswatpuneet commented Oct 30, 2024 •

edited

Loading