Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/developers section #54 #64

Merged
merged 17 commits into from
Nov 12, 2024

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented Nov 8, 2024

Description

Developers section, according to designs. Trying to get a single component to be style-able at the 3 different screen sizes was geting realllly messy, so I just broke up what I called the "Developer Steps" portion into 3 different components. That's also why I used a const object for text.

Type of change

  • Content Change (Required approval in Slack: #frequency-xyz and remember that changes along the way trigger
    re-approval.)
    • Approved HE (Required for technical wording)
    • Approved CM
    • Approved UO
  • New Feature

How to Test?

  1. Pull and run locally
  2. Page down to "Developers" section, and also click on the link in the Nav bar.
  3. Make sure you don't see any errors in console or showing up in the page.
  4. Compare with design

Checklist:

  • I have performed a self-review of my code
  • I have commented my code & PR, particularly in hard-to-understand areas
  • I have checked at all the breakpoints to make sure it works on all screen sizes

Copy link

github-actions bot commented Nov 8, 2024

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 6b1cf26

Copy link

github-actions bot commented Nov 8, 2024

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: b54d8b5

Copy link

github-actions bot commented Nov 8, 2024

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 03f60e5

Copy link

github-actions bot commented Nov 9, 2024

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 495c867

@shannonwells shannonwells changed the base branch from main to developer-portal November 9, 2024 05:06
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 8dddb03

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 7d2a193

@shannonwells shannonwells force-pushed the feat/developers-section-#54 branch from 77368cb to b0272ce Compare November 12, 2024 15:45
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 2199b06

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: daf2bc6

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 54e8fcd

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: b106748

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: cae8a64

@@ -46,6 +46,7 @@ export default tseslint.config(
'linebreak-style': ['error', 'unix'],
semi: 'warn',
'@typescript-eslint/ban-ts-comment': 'off',
'svelte/no-at-html-tags': 'off',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do individual exceptions via comment and something is broken (again)

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 9e49288

@shannonwells shannonwells marked this pull request as ready for review November 12, 2024 20:56
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 486fdaa

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 6af7c69

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 8350b77

@shannonwells shannonwells enabled auto-merge (squash) November 12, 2024 21:08

<a href="/docs"> Developer Portal </a>
<!-- Graphic and Header -->
<SectionWrapper id="developers" classes="sm:pt-[30px] md:pt-[38px] lg:pt-[34px]">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<SectionWrapper id="developers" classes="sm:pt-[30px] md:pt-[38px] lg:pt-[34px]">
<SectionWrapper id="developers" classes="freq-container sm:pt-[30px] md:pt-[38px] lg:pt-[34px]">

@shannonwells shannonwells force-pushed the feat/developers-section-#54 branch from b1daa16 to 5295db7 Compare November 12, 2024 21:31
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 1501b3b

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 6349896

Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an npm run format but once ci passes, ship it!

Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/64/
Commit: 24b4160

@shannonwells shannonwells merged commit 3a993b9 into developer-portal Nov 12, 2024
5 checks passed
@shannonwells shannonwells deleted the feat/developers-section-#54 branch November 12, 2024 22:13
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
@wilwade wilwade mentioned this pull request Nov 12, 2024
wilwade pushed a commit that referenced this pull request Nov 19, 2024
# Description
Developers section, according to designs. 
- Closes #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developers Section
2 participants