-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: phone and table rendering for main DevPortal page #71
feat: phone and table rendering for main DevPortal page #71
Conversation
🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content. Preview URL: https://www.frequency.xyz/_pr/71/ |
src/routes/+layout.svelte
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworked the main layout to Svelte 5 so that we could use a Snippet and wrap everything in a
debugScreens=true
in the file when running to enable.
src/components/HAccordion.svelte
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of my ongoing frontend education... removed most sm:...
classes in favor of <class> lg:<class>
, following recommended mobile-first development by Tailwind docs.
🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content. Preview URL: https://www.frequency.xyz/_pr/71/ |
🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content. Preview URL: https://www.frequency.xyz/_pr/71/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tried it on different phone & browser sizes.
# Description Render responsive design for phone & tablet. - Closes #33 ## Screenshot(s) <img width="378" alt="image" src="https://github.com/user-attachments/assets/0535423c-2327-42fb-9d10-a9d4517a7125"> <img width="378" alt="image" src="https://github.com/user-attachments/assets/36297975-8722-47a1-9da6-3b66b253f196"> <img width="378" alt="image" src="https://github.com/user-attachments/assets/7c371658-3718-4272-a358-304585d4fbeb"> - [x] New Feature # How to Test? 1. Pull and run locally 2. Go to "Developer Portal" page 3. See that the design at different sizes responds appropriately # Checklist: - [x] I have performed a self-review of my code - [x] I have commented my code & PR, particularly in hard-to-understand areas - [x] I have checked at all the breakpoints to make sure it works on all screen sizes
Description
Render responsive design for phone & tablet.
Screenshot(s)
How to Test?
Checklist: