Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

51 mission section #73

Merged
merged 5 commits into from
Nov 13, 2024
Merged

51 mission section #73

merged 5 commits into from
Nov 13, 2024

Conversation

claireclark1
Copy link
Contributor

Description

Screenshot(s)

Mobile:
Screenshot 2024-11-12 at 3 43 07 PM
Screenshot 2024-11-12 at 3 43 00 PM

Tablet:
Screenshot 2024-11-12 at 3 42 34 PM
Screenshot 2024-11-12 at 3 42 25 PM

Desktop:
Screenshot 2024-11-12 at 3 42 08 PM
Screenshot 2024-11-12 at 3 41 58 PM

Type of change

  • Approved HE (Required for technical wording)
  • Approved CM
  • Approved UO
  • New Feature

How to Test?

Run locally and check that it matches designs in all screen sizes.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code & PR, particularly in hard-to-understand areas
  • I have checked at all the breakpoints to make sure it works on all screen sizes

@claireclark1 claireclark1 self-assigned this Nov 12, 2024
@claireclark1 claireclark1 linked an issue Nov 12, 2024 that may be closed by this pull request
Mission Section #51
Closed
4 tasks
@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/73/
Commit: 41a9347

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/73/
Commit: 3e6e61d

@claireclark1 claireclark1 changed the base branch from main to developer-portal November 12, 2024 23:54
@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/73/
Commit: 15cd5ec

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/73/
Commit: f76185f

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/73/
Commit: 6b8824c

wilwade
wilwade approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Note: Content updates (tracked in a separate issue)

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/73/
Commit: 1562ef9

@claireclark1 claireclark1 merged commit b0ed771 into developer-portal Nov 13, 2024
5 checks passed
@claireclark1 claireclark1 deleted the 51-mission-section branch November 13, 2024 00:23
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
Remove PR preview for #73
2e62429
@wilwade wilwade mentioned this pull request Nov 13, 2024
Closed
4 tasks
wilwade pushed a commit that referenced this pull request Nov 19, 2024
@claireclark1 @wilwade
51 mission section (#73)
d9ab08e 
# Description

- Mission section content and styling in all screen sizes.

- Closes #51 

## Screenshot(s)
Mobile:
<img width="482" alt="Screenshot 2024-11-12 at 3 43 07 PM"
src="https://github.com/user-attachments/assets/b981399d-c9a4-49ae-864b-a6624f29a462">
<img width="478" alt="Screenshot 2024-11-12 at 3 43 00 PM"
src="https://github.com/user-attachments/assets/cfd8e549-1090-4843-bd66-68e969964c67">

Tablet:
<img width="941" alt="Screenshot 2024-11-12 at 3 42 34 PM"
src="https://github.com/user-attachments/assets/f200a4e1-4744-4e4a-a1a0-be310842c678">
<img width="923" alt="Screenshot 2024-11-12 at 3 42 25 PM"
src="https://github.com/user-attachments/assets/c513c95b-1b06-4793-872f-07b291215bac">

Desktop:
<img width="1470" alt="Screenshot 2024-11-12 at 3 42 08 PM"
src="https://github.com/user-attachments/assets/8ee45791-5613-448b-9c3b-997d4794cf94">
<img width="1457" alt="Screenshot 2024-11-12 at 3 41 58 PM"
src="https://github.com/user-attachments/assets/2de45707-64c3-4106-9aee-be9ad535e76e">


## Type of change

  - [X] Approved HE (Required for technical wording)
  - [ ] Approved CM
  - [ ] Approved UO
- [X] New Feature

# How to Test?

Run locally and check that it matches designs in all screen sizes.

# Checklist:

- [X] I have performed a self-review of my code
- [X] I have commented my code & PR, particularly in hard-to-understand
areas
- [X] I have checked at all the breakpoints to make sure it works on all
screen sizes

---------

Co-authored-by: Claire Olmstead <olmsteadclaire@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilwade wilwade wilwade approved these changes

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055

@shannonwells shannonwells Awaiting requested review from shannonwells

@mattheworris mattheworris Awaiting requested review from mattheworris

@enddynayn enddynayn Awaiting requested review from enddynayn

Assignees

@claireclark1 claireclark1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mission Section
2 participants
@claireclark1 @wilwade