Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact form #81

Merged
merged 10 commits into from
Nov 15, 2024
Merged

Contact form #81

merged 10 commits into from
Nov 15, 2024

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented Nov 14, 2024 •
edited
Loading

Description

Screenshot(s)

Type of change

  • Content Change (Required approval in Slack: #frequency-xyz and remember that changes along the way trigger
    re-approval.)
    • Approved HE (Required for technical wording)
    • Approved CM
    • Approved UO
  • New Feature

How to Test?

Because the "goto" takes you to "/" which is frequency.xyz/ and not the PR link, to verify the form clearing behavior you can try it locally.

You also may need to allow site trackers.

git fetch && git checkout contact-section-#56
npm run dev # this disables actually POSTing to the endpoint and will always succeed.
  1. Click on 'Contact' in the menu bar
  2. Click submit and see that the error fields are marked.
  3. Fill it out partially, click submit and see that the unfilled required fields are marked
  4. Fill it out entirely & click submit, see that you get the "Thank you" card.
  5. Click the card and you should be
    a. scrolled to the top
    b. if you scroll back down, the form should be cleared.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code & PR, particularly in hard-to-understand areas
  • I have checked at all the breakpoints to make sure it works on all screen sizes

@shannonwells shannonwells changed the title form validation working Contact form Nov 14, 2024
shannonwells
shannonwells commented Nov 14, 2024
View reviewed changes
src/components/GetNotified/GetNotified.svelte

$: inputClasses = hasSubmittedFormAtLeastOnce ? invalidInputClasses : validInputClasses;
const goToTop = async (_e: Event) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what else to do after a submit when they click "Thank you" card.

shannonwells
shannonwells commented Nov 14, 2024
View reviewed changes
src/lib/util/forms.ts
@@ -0,0 +1,6 @@
import { type ClassValue, clsx } from 'clsx';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was lifted from bit-ui

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/81/
Commit: 10446cc

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/81/
Commit: dc2a920

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/81/
Commit: d301e89

@shannonwells shannonwells marked this pull request as ready for review November 14, 2024 22:00
@shannonwells shannonwells marked this pull request as draft November 14, 2024 22:00
@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/81/
Commit: a07cea9

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/81/
Commit: e56e566

@shannonwells shannonwells marked this pull request as ready for review November 14, 2024 22:30
@shannonwells shannonwells enabled auto-merge (squash) November 14, 2024 22:31
@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/81/
Commit: 50ba7f7

@github-actions GitHub Actions
Copy link

🚀 Preview deployment for this PR is going up! Remember you might need to hard refresh to get the new content.

Preview URL: https://www.frequency.xyz/_pr/81/
Commit: 54bc251

wilwade
wilwade approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wilwade wilwade merged commit 669d400 into developer-portal Nov 15, 2024
5 checks passed
@wilwade wilwade deleted the contact-section-#56 branch November 15, 2024 13:00
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
Remove PR preview for #81
191ab09
@wilwade wilwade mentioned this pull request Nov 15, 2024
Closed
3 tasks
wilwade added a commit that referenced this pull request Nov 19, 2024
@shannonwells @wilwade
Contact form (#81)
ec10393 
# Description

- Closes #56

---------

Co-authored-by: Wil Wade <wil.wade@projectliberty.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilwade wilwade wilwade approved these changes

@claireclark1 claireclark1 Awaiting requested review from claireclark1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shannonwells @wilwade