Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonce: increase for free tnx and existing accounts #1805

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Dec 5, 2023

Goal

The goal of this PR is to allow increase of nonce for free transactions on existing accounts

Closes #1766

Checklist

  • Test added
  • e2e tests updated

@aramikm aramikm requested a review from wilwade as a code owner December 5, 2023 20:38
@aramikm aramikm requested a review from a team December 5, 2023 20:39
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (701a0ba) 82.17% compared to head (a0e238d) 82.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1805   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files          52       52           
  Lines        4022     4022           
=======================================
  Hits         3305     3305           
  Misses        717      717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

  • Reviewed issue
  • Reviewed code
  • Tested locally
  • Matches all my expectations

Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice!

@aramikm aramikm merged commit 2412d55 into main Dec 8, 2023
30 checks passed
@aramikm aramikm deleted the nonce_increase_free_trx_existing_account branch December 8, 2023 19:17
@wilwade wilwade added the change/major Major Changes in this PR label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change/major Major Changes in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepaid (free) transactions should still increment the nonce for accounts that have an Account
5 participants