Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore Update Benchmark Standard #1843

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Chore Update Benchmark Standard #1843

merged 3 commits into from
Mar 8, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Jan 17, 2024 •
edited
Loading

Goal

The goal of this PR is to update the benchmarks using the new standard

Closes #1786

@wilwade wilwade force-pushed the chore/update-benchmarks branch from 697d951 to 92f1432 Compare January 17, 2024 14:45
@github-actions GitHub Actions
Copy link

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@wilwade wilwade mentioned this pull request Jan 17, 2024
Closed
demisx pushed a commit that referenced this pull request Jan 17, 2024
@do-not-reply
Update weights for PR #1843
2aba9c3
@github-actions GitHub Actions
Copy link

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 2aba9c3.

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.11%. Comparing base (41a758b) to head (25e3ed9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1843   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files          56       56           
  Lines        4525     4525           
=======================================
  Hits         3761     3761           
  Misses        764      764

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jan 17, 2024
wilwade pushed a commit that referenced this pull request Mar 5, 2024
@do-not-reply @wilwade
Update weights for PR #1843
a134ad4
@wilwade wilwade force-pushed the chore/update-benchmarks branch from 2aba9c3 to a134ad4 Compare March 5, 2024 14:25
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Mar 5, 2024
@wilwade wilwade force-pushed the chore/update-benchmarks branch from a134ad4 to dc83205 Compare March 5, 2024 17:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit e697ce6.

demisx pushed a commit that referenced this pull request Mar 5, 2024
@do-not-reply
Update weights for PR #1843
e697ce6
@wilwade wilwade force-pushed the chore/update-benchmarks branch from e697ce6 to b392187 Compare March 6, 2024 13:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 480c4e0.

demisx pushed a commit that referenced this pull request Mar 6, 2024
@do-not-reply
Update weights for PR #1843
480c4e0
@wilwade wilwade force-pushed the chore/update-benchmarks branch from 480c4e0 to b392187 Compare March 6, 2024 14:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit f283580.

demisx pushed a commit that referenced this pull request Mar 6, 2024
@do-not-reply
Update weights for PR #1843
f283580
@wilwade wilwade marked this pull request as ready for review March 6, 2024 18:36
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Mar 6, 2024
wilwade pushed a commit that referenced this pull request Mar 7, 2024
@do-not-reply @wilwade
Update weights for PR #1843
d9b0eba
@wilwade wilwade force-pushed the chore/update-benchmarks branch from f283580 to d9b0eba Compare March 7, 2024 14:53
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Mar 7, 2024
wilwade pushed a commit that referenced this pull request Mar 7, 2024
@do-not-reply @wilwade
Update weights for PR #1843
ae5db44
@wilwade wilwade force-pushed the chore/update-benchmarks branch from d9b0eba to ae5db44 Compare March 7, 2024 17:40
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Mar 7, 2024
@wilwade wilwade requested a review from mattheworris March 7, 2024 18:31
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Mar 7, 2024
mattheworris
mattheworris approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Mar 7, 2024
shannonwells
shannonwells approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, noted a few significant weight changes but nothing alarming.

aramikm
aramikm approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good only 2 considerations:

  • While it looks like that this should be using a new instance the comments on header suggests the same CPU "Intel(R) Xeon(R) Platinum 8375C CPU @ 2.90GHz"
  • We might want to rerun the database benchmarks using the latest chain state to make sure our DB benchmarks are updated

pallets/time-release/src/weights.rs
// Minimum execution time: 32_236_000 picoseconds.
Weight::from_parts(33_078_000, 6399)
// Minimum execution time: 48_134_000 picoseconds.
Weight::from_parts(48_875_000, 6399)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting increase here

@wilwade wilwade force-pushed the chore/update-benchmarks branch from 4dabc03 to 25e3ed9 Compare March 7, 2024 22:38
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Mar 7, 2024
@wilwade
Copy link
Collaborator Author

wilwade commented Mar 7, 2024

@aramikm

  • While it looks like that this should be using a new instance the comments on header suggests the same CPU "Intel(R) Xeon(R) Platinum 8375C CPU @ 2.90GHz"

It is still that CPU. The big change is that the memory was increased.

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Mar 7, 2024
@wilwade wilwade merged commit b871aac into main Mar 8, 2024
31 checks passed
@wilwade wilwade deleted the chore/update-benchmarks branch March 8, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonwells shannonwells shannonwells approved these changes

@mattheworris mattheworris mattheworris approved these changes

@aramikm aramikm aramikm approved these changes

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Frequency Benchmarking Standard
7 participants
@wilwade @shannonwells @mattheworris @aramikm @saraswatpuneet @JoeCap08055 @do-not-reply