fix: MSA owner should be able to invoke non-signature methods on SignatureRequired schemas directly

[JoeCap08055]

Goal

The goal of this PR is to make it possible for MSA owners to call non-signature stateful-storage methods directly without requiring a separate payload signature.

Adds e2e test scenarios to validate this correct behavior for both signature and non-signature stateful-storage extrinsics

Closes #1793

Discussion

Testing

• Run e2e tests for the stateful-storage pallet against an unmodified frequency chain; should result in ~ 6 errors
• Run e2e tests against a locally-built chain from this branch; errors should be resolved

TODO

• Add Rust unit tests

Checklist

• Chain spec updated
• Custom RPC OR Runtime API added/changed? Updated js/api-augment.
• Design doc(s) updated
• Tests added
• Benchmarks added
• Weights updated

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70aec76) 82.90% compared to head (96702d5) 82.95%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1844      +/-   ##
==========================================
+ Coverage   82.90%   82.95%   +0.04%     
==========================================
  Files          56       56              
  Lines        4540     4552      +12     
==========================================
+ Hits         3764     3776      +12     
  Misses        776      776              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wilwade]

These aren't the signature require extrinsics, but I think all of your tests should pass without any changes to the lib.rs due to https://github.com/LibertyDSNP/frequency/blob/c92466510fb78a4885a8977d1d7444916ff77465/pallets/stateful-storage/src/lib.rs#L762-L763

[JoeCap08055]

These aren't the signature require extrinsics, but I think all of your tests should pass without any changes to the lib.rs due to

https://github.com/LibertyDSNP/frequency/blob/c92466510fb78a4885a8977d1d7444916ff77465/pallets/stateful-storage/src/lib.rs#L762-L763

That's right; these aren't the signature required extrinsics. That's not the point of the PR; in fact, I pointed out in the original issue here that the problem seems to have been mis-stated. The signature-required extrinsics always worked correctly with a signature on a SignatureRequired schema, but I believe the non-signature extrinsics should also work for said schemas if invoked by the schema owner.

I verified that against the current Frequency release, my new e2e tests fail; with these modifications, they pass.

[wilwade]

That's right; these aren't the signature required extrinsics. That's not the point of the PR; in fact, I pointed out in the original issue here that the problem seems to have been mis-stated. The signature-required extrinsics always worked correctly with a signature on a SignatureRequired schema, but I believe the non-signature extrinsics should also work for said schemas if invoked by the schema owner.

Ah I see now. Sorry about that. I missed connecting this with the other. Calling the normal one instead of the with_signature is a nice way around this issue.

Will re-review.

[wilwade]

Now that I understand what is going on, this is a great fix! A few notes, but my guess is that those were mostly already on your todo list for before it gets out of draft mode

[wilwade]

I haven't run the code locally, but this captures a nice simple solution to the problem with minimal code changes. (and a lot of new tests)

• Read code
• Validated it solves the original issue

[aramikm]

Looks good, added some nits. Spec version needs to get updated!

• Ran the local chain
• Ran unit & e2e tests

[shannonwells]

I only reviewed the code, had read the related issue + discussion fairly well. Looks like an elegant solution to me. One naming suggestion but NBD.

[enddynayn]

wonderful! 👍