Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS Packages #2249

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Update JS Packages #2249

merged 3 commits into from
Jan 3, 2025

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Jan 3, 2025

Goal

The goal of this PR is regular updates to the JS packages

Discussion

  • The metadata comparison has also been broken and the most recent updates required us to use the dev version instead of the mainnet version
  • Updated:
    • API-Augment
    • Schemas
    • E2E Tests
    • Tools
    • Metadata comparison in release

@wilwade wilwade requested a review from a team January 3, 2025 21:39
@wilwade wilwade requested a review from demisx as a code owner January 3, 2025 21:39
@wilwade wilwade enabled auto-merge (squash) January 3, 2025 21:39
@@ -512,10 +512,9 @@ jobs:
name: Compare Metadata
Copy link
Collaborator Author

@wilwade wilwade Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to test this locally?

  1. Download two release dev images to a folder and name them frequency.amd64 and frequency-ref.amd64 and make sure they are in your current folder.
  2. docker network create net-1153
  3. docker pull jacogr/polkadot-js-tools:0.61.2
docker run --platform=linux/amd64 --rm --net=net-1153 \
            -v `pwd`:/app \
            --name test-node \
            ubuntu:24.04 \
              /bin/sh -c "chmod +x /app/frequency.amd64 && /app/frequency.amd64 \
              --chain=dev \
              --rpc-external \
              --rpc-cors=all \
              --rpc-methods=Unsafe \
              --no-telemetry \
              --no-prometheus \
              --reserved-only \
              --no-hardware-benchmarks \
              --tmp \
              -- \
              --no-telemetry \
              --reserved-only"
docker run --platform=linux/amd64 --rm --net=net-1153 \
            -v `pwd`:/app \
            --name ref-node \
            ubuntu:24.04 \
              /bin/sh -c "chmod +x /app/frequency-ref.amd64 && /app/frequency-ref.amd64 \
              --chain=dev \
              --rpc-external \
              --rpc-cors=all \
              --rpc-methods=Unsafe \
              --no-telemetry \
              --no-prometheus \
              --reserved-only \
              --no-hardware-benchmarks \
              --tmp \
              -- \
              --no-telemetry \
              --reserved-only"
  1. docker run --platform=linux/amd64 --net=net-1153 jacogr/polkadot-js-tools:0.61.2 metadata ws://ref-node:9944 ws://test-node:9944

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 great!

Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code changes and ran the local test scripts/dockers, all works.

@wilwade wilwade merged commit f521746 into main Jan 3, 2025
28 checks passed
@wilwade wilwade deleted the chore/update-js-packages branch January 3, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants