-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JS Packages #2249
Update JS Packages #2249
Conversation
@@ -512,10 +512,9 @@ jobs: | |||
name: Compare Metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to test this locally?
- Download two release dev images to a folder and name them frequency.amd64 and frequency-ref.amd64 and make sure they are in your current folder.
docker network create net-1153
docker pull jacogr/polkadot-js-tools:0.61.2
docker run --platform=linux/amd64 --rm --net=net-1153 \
-v `pwd`:/app \
--name test-node \
ubuntu:24.04 \
/bin/sh -c "chmod +x /app/frequency.amd64 && /app/frequency.amd64 \
--chain=dev \
--rpc-external \
--rpc-cors=all \
--rpc-methods=Unsafe \
--no-telemetry \
--no-prometheus \
--reserved-only \
--no-hardware-benchmarks \
--tmp \
-- \
--no-telemetry \
--reserved-only"
docker run --platform=linux/amd64 --rm --net=net-1153 \
-v `pwd`:/app \
--name ref-node \
ubuntu:24.04 \
/bin/sh -c "chmod +x /app/frequency-ref.amd64 && /app/frequency-ref.amd64 \
--chain=dev \
--rpc-external \
--rpc-cors=all \
--rpc-methods=Unsafe \
--no-telemetry \
--no-prometheus \
--reserved-only \
--no-hardware-benchmarks \
--tmp \
-- \
--no-telemetry \
--reserved-only"
docker run --platform=linux/amd64 --net=net-1153 jacogr/polkadot-js-tools:0.61.2 metadata ws://ref-node:9944 ws://test-node:9944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code changes and ran the local test scripts/dockers, all works.
Goal
The goal of this PR is regular updates to the JS packages
Discussion