Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break hash #174

Merged
merged 2 commits into from
Sep 26, 2024
Merged

break hash #174

merged 2 commits into from
Sep 26, 2024

Conversation

claireclark1
Copy link
Contributor

@claireclark1 claireclark1 commented Sep 25, 2024 •
edited
Loading

Goal

The goal of this PR is to wrap the long hash string

Closes #170

Discussion

  • wrap long string
  • check for any other instances

Checklist

  • [ x] PR Self-Review and Commenting
  • [n/a] Docs updated
  • [n/a] Tests added

How To Test the Changes

  1. Clone the pr branch
  2. trigger error on signup/become a provider flow
  3. see error message abiding by margins

Demo

Screenshot 2024-09-25 at 1 53 50 PM Screenshot 2024-09-26 at 3 22 05 PM

@claireclark1 claireclark1 self-assigned this Sep 25, 2024
@claireclark1 claireclark1 linked an issue Sep 25, 2024 that may be closed by this pull request
BUG: needs text wrap on long error #170
Closed
@claireclark1 claireclark1 force-pushed the 170-bug-needs-text-wrap-on-long-error branch from 759b9b2 to 4381314 Compare September 26, 2024 22:24
shannonwells
shannonwells approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, looks like the break is fixed.

@claireclark1 claireclark1 merged commit ce598ca into main Sep 26, 2024
3 checks passed
@claireclark1 claireclark1 deleted the 170-bug-needs-text-wrap-on-long-error branch September 26, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonwells shannonwells shannonwells approved these changes

Assignees

@claireclark1 claireclark1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: needs text wrap on long error
2 participants
@claireclark1 @shannonwells