-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme update #198
base: main
Are you sure you want to change the base?
Theme update #198
Conversation
@@ -14,7 +14,7 @@ | |||
|
|||
<button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/FAQItem.svelte
Outdated
@@ -14,7 +14,7 @@ | |||
|
|||
<button | |||
id="faq-question" | |||
class="label text-md mt-2 flex w-full items-center justify-between border-t border-divider p-4 text-left" | |||
class="label border-divider mt-2 flex w-full items-center justify-between border-t p-4 text-left text-md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, it doesn't seem to match the style guide. Either import the one from the SG, or abide by the styles here: https://www.figma.com/design/EjFt1XdacOogDZoQ7RetrI/Frequency-Style-Guidelines?node-id=1072-1096&node-type=frame&t=M9rvMiiDpjs2zIh5-0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Tweaks for mobile to header with connection status * icons and hovering and buttons * prettier
ad32a79
to
f1fe39e
Compare
Screen.Recording.2024-12-03.at.12.31.00.PM.movDoesn't look like the button is disabled on hover. |
A couple of places I think need improvements but can be done in other stories.
|
Screen.Recording.2024-12-03.at.1.03.43.PM.movThe copy button is white now so you cant see it. change to black or navy. Also needs to be centered. |
Screen.Recording.2024-12-03.at.1.13.51.PM.movThe switch SVG in the upper right is not rendering correctly in all pages. |
Screen.Recording.2024-12-03.at.1.15.52.PM.movThere is no longer a hover state on the nav bar. |
Goal
The goal of this PR is to pull in the Style Guide and use it where possible, and otherwise make the style match what is on Frequency.xyz and other branded sites.
Known bug: after changing networks the path is appended and not cleared first. One result is the Nav indicator for the current page disappears. See #197
Not included: updates to styles, given we do not have mocks for the new style for this site.
Closes #195
Checklist
How To Test the Changes
git fetch && git checkout theme-update npm run dev