respond to comments

frequency-chain · Nov 26, 2024 · e2f9d88 · e2f9d88
1 parent ef7a5bd
commit e2f9d88
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 20 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -64,7 +64,6 @@
     "vite": "^4.4.9"
   },
   "dependencies": {
-    "@melt-ui/svelte": "^0.86.2",
     "@storybook/addons": "^7.6.17",
     "bits-ui": "^0.21.16",
     "clsx": "^2.1.1",

diff --git a/src/lib/atoms/FormElement.svelte b/src/lib/atoms/FormElement.svelte
@@ -5,10 +5,13 @@
   export let isRequired = false;
   export let description = '';
   export let error: string | undefined;
+
+  const labelNoSpaces = label.split(' ').join('');
+  const id = `form-element-${labelNoSpaces}`;
 </script>
 
 <div class="flex flex-col gap-f4">
-  <label class="form-item-label" for="form-element">
+  <label class="form-item-label" for={id}>
     {label}
     {#if isRequired}
       <span class="text-error">*</span>
@@ -19,7 +22,7 @@
     <span class="form-item-description">{description}</span>
   {/if}
 
-  <div class="flex items-center gap-f12" id="form-element">
+  <div class="flex items-center gap-f12" {id}>
     <slot />
 
     {#if error}