Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacing story #26

Merged
merged 2 commits into from
Oct 18, 2024
Merged

spacing story #26

merged 2 commits into from
Oct 18, 2024

Conversation

claireclark1
Copy link
Collaborator

Problem

Define spacing

closes #4

Solution

  • By setting spacing, we're defining pixel values that can be used across all types of styling, such as gap, padding, width, etc.
  • Create a storybook to display.
  • Added the "f" prefix to the values to indicate that it's frequency's style-guide values and to not override the defaults, potentially breaking a lot of formatting.

Steps to Verify:

  1. Check that spacing looks good on the storybook

Screenshots (optional):

Screenshot 2024-10-11 at 12 21 50 PM

@claireclark1 claireclark1 self-assigned this Oct 11, 2024
@claireclark1 claireclark1 linked an issue Oct 11, 2024 that may be closed by this pull request
@claireclark1 claireclark1 merged commit 7c14454 into main Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing
1 participant