Update header and button #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
commented
Nov 11, 2024
| @@ -1,7 +1,7 @@ | |||
| <svg viewBox="0 0 28 22" fill="none" xmlns="http://www.w3.org/2000/svg" class={$$restProps.class}> | |||
| <path | |||
| d="M2 20H25.625M2 11H25.625M2 2H25.625" | |||
| stroke="black" | |||
| stroke="currentColor" | |||
There was a problem hiding this comment.
This way the color can be set correctly for the icon
wilwade
commented
Nov 11, 2024
| @@ -64,7 +64,7 @@ | |||
| <aside>Click it!</aside> | |||
| <svelte:component this={Icon} class="mb-1 h-8 w-auto stroke-black" isDemo={true} /> | |||
| {:else} | |||
| <svelte:component this={Icon} class="mb-1 h-8 w-auto" isDemo={true} /> | |||
| <svelte:component this={Icon} class="mb-1 h-8 w-auto stroke-black" isDemo={true} /> | |||
There was a problem hiding this comment.
For the story book view
wilwade
commented
Nov 11, 2024
| @@ -50,7 +54,14 @@ | |||
| <a {...$$restProps} {href} class={disabled ? 'pointer-events-none block' : 'pointer-events-auto block'}> | |||
| <button | |||
| {...$$restProps} | |||
| class={`rounded-full px-f24 py-f8 text-center transition-all ${btnStylesClass} ${btnSizeClass} ${$$restProps.class ?? ''}`} | |||
| class={cn( | |||
There was a problem hiding this comment.
Swap to cn here so that we can just dump in the classes and have them resolve correctly
wilwade
commented
Nov 11, 2024
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| <input type="checkbox" class="peer hidden" bind:checked={isOpen} id={toggleIdentifier} /> | |||
| <OpenClose | |||
| classes="cursor-pointer stroke-navy peer-checked:stroke-white peer-checked:hover:stroke-teal hover:stroke-teal flex self-center lg:hidden" | |||
| classes="cursor-pointer text-navy peer-checked:text-white peer-checked:hover:text-teal hover:text-teal flex self-center lg:hidden" | |||
There was a problem hiding this comment.
Text color works better with currentColor for browsers
wilwade
commented
Nov 11, 2024
| @@ -1,6 +1,7 @@ | |||
| export default { | |||
| //Branding Colors | |||
| navy: '#14313F', | |||
| navyLight: '#18465E', | |||
There was a problem hiding this comment.
Finally used in a style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Screenshots (optional):