Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add svelte-check to github workflows #69

Merged
merged 4 commits into from
Dec 2, 2024
Merged

add svelte-check to github workflows #69

merged 4 commits into from
Dec 2, 2024

Conversation

claireclark1
Copy link
Collaborator

@claireclark1 claireclark1 commented Dec 2, 2024 •
edited
Loading

Problem

Add svelte-check to github workflows and resolve any errors.

Also add prettier checks.

closes #67

Steps to Verify:

  1. See that svelte-check is running in the github checks below.
  2. See that prettier is running in the github checks below.

@claireclark1 claireclark1 linked an issue Dec 2, 2024 that may be closed by this pull request
Add svelte-check to GitHub workflows - Styleguide #67
Closed
@claireclark1 claireclark1 self-assigned this Dec 2, 2024
wilwade
wilwade approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@claireclark1 claireclark1 merged commit 5c7db2a into main Dec 2, 2024
7 checks passed
@claireclark1 claireclark1 deleted the 67-add-svelte-check-to-github-workflows---styleguide branch December 2, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilwade wilwade wilwade approved these changes

@shannonwells shannonwells Awaiting requested review from shannonwells

Assignees

@claireclark1 claireclark1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add svelte-check to GitHub workflows - Styleguide
2 participants
@claireclark1 @wilwade