Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form can be valid regardless of order filling out #28

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

shannonwells
Copy link

@shannonwells shannonwells commented Sep 27, 2024

Goal

This adjusts the faucet form validation to allow the submit button to be enabled regardless of the order of clicking captcha or filling in an address. Address validation isn't performed until focusout fires. A little trickier to fix than at first blush.

Also did a yarn update to fix a browserslist warning. Thanks to @JoeCap08055 for the nudge to turn this into an issue.

Closes #27

Checklist

  • PR Self-Review and Commenting
  • Tests added

How To Test the Changes

  1. Clone the pr branch
  2. Set PUBLIC_DEMO_MODE=true in client/.env and launch:
cd client
yarn install --freeze-lockfile && yarn dev
  1. Then verify that you can click Captcha and then fill out the address, and the Submit button is enabled, as well as vice versa.
  2. Verify that the address is still validated correctly.

Copy link

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change to me.

@shannonwells shannonwells merged commit e2b45b8 into main Sep 30, 2024
6 checks passed
@shannonwells shannonwells deleted the bug/form-#27 branch September 30, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Click captcha first and then enter an address, the submit button is never enabled
2 participants