ESService Decorator #142
Merged
ESService Decorator #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 943c8ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
One point of note: this is in contrib/ now, but I imagine as pre-5.0 decorators are phased out, We're shipping this in contrib/ now to avoid bundling two service implementations. |
freshgum-bubbles
force-pushed
the
feat/es-decorators
branch
from
7a5666a to
81cda7f
Compare
This marks a pretty good milestone for development. We've got the Service test suite passing with ESService, and we've also ensured a few other things in the ESService-specific testing suite.
Preemptive Prettier scan to avoid CI.
Curse you, VSCode auto refactoring.
freshgum-bubbles
force-pushed
the
feat/es-decorators
branch
from
268d76a to
464c8e4
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces ES Decorators as a contributory package.
These decorators mirror their non-ES counterparts in the main
package.
As the package only contains one decorator, we only have to
focus on the Service decorator.