Make ESService support static props #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c247207 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
freshgum-bubbles
added
bug
freshgum-bubbles
force-pushed
the
fix/esservice-support-static-properties
branch
2 times, most recently
from
0f6da87 to
a3825b7
Compare
ESService does not support static properties or methods, as the types are broken. This change fixes that issue by refactoring the generic types that the ESService function accepts.
This brings back compatibility with the former API, making this a minor change (yay!)
freshgum-bubbles
force-pushed
the
fix/esservice-support-static-properties
branch
from
01e48f4 to
788399b
Compare
Change the types to stop expecting the options to be of type ServiceOptions<Constructable<Constructable<T>>, as most users don't want to wrap constructables twice (lame, right).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESService does not support static properties or methods, as the types are broken. This change fixes that issue by refactoring the generic types that the ESService function accepts.
Fixes #194