feat(fw-list-options): Virtualise list options #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rihansiddhi
force-pushed
the
feat/virtual-scroll
branch
from
054f72c
to
2de81fb
Compare
arvindanta
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Tanstack Virtual library by creating an adapter for stencil to achieve virtual scroll.
Checklist:
How Has This Been Tested?
Screen.Recording.2023-11-23.at.10.58.30.AM.mov
Documentation: Necessary documentation to add this utility to a component is available as comments on top of the utility.
Testing: We have introduced a virtual scroll stencil adapter. Testing this adapter should be a part of the component using this adapter. Hence, added Necessary UT in file-library component.