[FC-120761][FE]:adding sla timer fields in fw-field-editor #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elayaraman
force-pushed
the
pause-sla-timer
branch
from
3539633
to
7b55e87
Compare
…sing the feature flag
…sing the feature flag
Elayaraman
changed the title
prasanna-vijayan
approved these changes
Apr 4, 2024
prasanna-vijayan
assigned prasanna-vijayan and Elayaraman and unassigned prasanna-vijayan
rihansiddhi
reviewed
Apr 4, 2024
| 'resolution_timer', | ||
| dataItem.choice_options.resolution_timer | ||
| )} | ||
| {dataItem?.choice_options?.pause_resolution_sla_timer !== |
There was a problem hiding this comment.
@Elayaraman Shouldn't we be checking if isSlaEnabled is true here?
There was a problem hiding this comment.
Yeah It should be
I have made the changes
rihansiddhi
reviewed
Apr 4, 2024
| @@ -1352,7 +1364,21 @@ export class FieldEditor { | |||
| ></fw-input> | |||
| </div> | |||
| </span> | |||
| {toggle} | |||
| {isSlaEnabled && | |||
There was a problem hiding this comment.
@Elayaraman Do we need to have isSlaEnabled check here as this is for resolution_timer?
There was a problem hiding this comment.
No need for it here
mistakenly added
rihansiddhi
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
How Has This Been Tested?
This change is made to add new toggle in conversation properies (status)
when we passing a feature flag from the FE
so it will be dynamic according to the value we are passing