Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component): showRelationshipTypeSelect based on config provided by the products #939

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

abisht1991
Copy link
Collaborator

@abisht1991 abisht1991 commented Sep 25, 2024

showRelationshipTypeSelect based on config provide by the products default value being true.

As we need that support in conversation properties when custom objects is enabled as part of one UCR effort.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

…ded by the products

showRelationshipTypeSelect based on config provide by the products default value being true
Copy link
Collaborator

@aishik-biswas aishik-biswas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@prasanna-vijayan prasanna-vijayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prasanna-vijayan prasanna-vijayan merged commit 86cb013 into next Sep 30, 2024
1 check passed
@prasanna-vijayan prasanna-vijayan deleted the showRelationshipTypeSelect-props branch September 30, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants