Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Switches to ruff for code quality #85

Merged
merged 9 commits into from
Jan 27, 2024
Merged

style: Switches to ruff for code quality #85

merged 9 commits into from
Jan 27, 2024

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Jan 27, 2024

This PR introduces the following modifications:

  • removes flake8, black, bandit, pydocstyle and replaces it with ruff
  • updates precommit, CI, makefile and docs
  • numps mypy to 1.8.0
  • fixes lint & typing issues

@frgfm frgfm added the type: improvement New feature or request label Jan 27, 2024
@frgfm frgfm added this to the 0.2.0 milestone Jan 27, 2024
@frgfm frgfm self-assigned this Jan 27, 2024
@github-actions github-actions bot added topic: docs Improvements or additions to documentation module: utils Related to utils module: crawler Related to crawler module: modules Related to modules module: process Related to process topic: build Related to project build ext: scripts Related to scripts topic: ci ext: tests labels Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f4e4e42) 92.95% compared to head (0427141) 93.10%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   92.95%   93.10%   +0.15%     
==========================================
  Files          10       10              
  Lines         667      653      -14     
==========================================
- Hits          620      608      -12     
+ Misses         47       45       -2     
Files Coverage Δ
torchscan/__init__.py 100.00% <100.00%> (+33.33%) ⬆️
torchscan/crawler.py 84.32% <100.00%> (ø)
torchscan/modules/__init__.py 100.00% <100.00%> (ø)
torchscan/modules/flops.py 97.51% <100.00%> (ø)
torchscan/modules/macs.py 100.00% <100.00%> (ø)
torchscan/modules/memory.py 100.00% <100.00%> (ø)
torchscan/utils.py 100.00% <100.00%> (ø)
torchscan/modules/receptive.py 83.78% <75.00%> (ø)
torchscan/process/memory.py 39.13% <50.00%> (ø)

@frgfm frgfm merged commit 2dc4d3d into main Jan 27, 2024
26 of 27 checks passed
@frgfm frgfm deleted the ruff branch January 27, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: scripts Related to scripts ext: tests module: crawler Related to crawler module: modules Related to modules module: process Related to process module: utils Related to utils topic: build Related to project build topic: ci topic: docs Improvements or additions to documentation type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant