Skip to content

fix: handle nil values for instance attributes in GetDeployedInstances #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hskiba merged 1 commit into from
May 15, 2025
Merged

fix: handle nil values for instance attributes in GetDeployedInstances #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions adapter/aws/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,19 +149,27 @@ func GetDeployedInstances(c chan RegionSummary, region string, tags map[string]s

for _, res := range result.Reservations {
for _, inst := range res.Instances {
instance.ID = *inst.InstanceId
if inst.InstanceId != nil {
instance.ID = *inst.InstanceId
}
instance.Status = inst.State.Name
instance.Type = inst.InstanceType
instance.IP = *inst.PrivateIpAddress
instance.Hibernation = *inst.HibernationOptions.Configured
if inst.PrivateIpAddress != nil {
instance.IP = *inst.PrivateIpAddress
}
if inst.HibernationOptions != nil && inst.HibernationOptions.Configured != nil {
instance.Hibernation = *inst.HibernationOptions.Configured
}
instance.Region = region
instance.AZ = getInstanceAZ(resultStatus.InstanceStatuses, inst.InstanceId)
if inst.InstanceId != nil {
instance.AZ = getInstanceAZ(resultStatus.InstanceStatuses, inst.InstanceId)
}
instance.SpotInstanceType = ""
if inst.InstanceLifecycle == "" {
instance.Lifecycle = string(types.InstanceLifecycleOnDemand)
} else {
instance.Lifecycle = string(inst.InstanceLifecycle)
if inst.InstanceLifecycle == types.InstanceLifecycleTypeSpot {
if inst.InstanceLifecycle == types.InstanceLifecycleTypeSpot && inst.SpotInstanceRequestId != nil {
instance.SpotInstanceType = getSpotRequestType(spotDetail.SpotInstanceRequests, inst.SpotInstanceRequestId)
}
}
Expand Down
Loading