Compatibility with PHPUnit 11 #61
Conversation
shulard
force-pushed
the
chore/phpunit-php-code-coverage-11
branch
from
c35f820 to
175d840
Compare
|
Hello @jaylinski ! This PR is to handle the PHPunit 11 update. I added an exception to handle the deprecation for the blacklist options. Let me know if it’s fine for you ^^ If we merge this one, we must tag a new minor release then we can create a new major after removing the blacklist options. |
shulard
force-pushed
the
chore/phpunit-php-code-coverage-11
branch
2 times, most recently
from
d6c8bb5 to
fc0886d
Compare
|
It looks like I find a way to deal with the blacklist options. The FileIterator library provide the ability to exclude some file and folders so I refactored the code to use this. We can think about dropping this option but it must be fine for now to keep it ^^ |
| @@ -35,7 +35,7 @@ public function let(ConsoleIO $io, Driver $driver) | |||
| public function it_can_process_all_directory_filtering_options(SuiteEvent $event) | |||
| { | |||
| $this->setOptions([ | |||
| 'blacklist' => [ | |||
| 'whitelist' => [ | |||
There was a problem hiding this comment.
I think we should add a dedicated blacklist-test.
Otherwise our code-coverage will drop.
Sadly the CI pipeline didn't upload the code-coverage to Scrutinizer (https://scrutinizer-ci.com/g/friends-of-phpspec/phpspec-code-coverage/), maybe something is broken there.
There was a problem hiding this comment.
It has been pushed but you need to check the inspections. The dashboard page is only displaying master build.
Here is the result for the latest push: https://scrutinizer-ci.com/g/friends-of-phpspec/phpspec-code-coverage/inspections/8024bdbd-49db-4a89-91b3-d0a179fdf1e5
shulard
force-pushed
the
chore/phpunit-php-code-coverage-11
branch
from
fc0886d to
c914e43
Compare
Also require phpunit/php-file-iterator which is used to find the files to include.
Since the phpunit/php-code-coverage isn't able to exclude any folder from version 11, we must handle that logic differently. We now compute a list of files and folder to be excluded and we give it to the filter.
shulard
force-pushed
the
chore/phpunit-php-code-coverage-11
branch
from
c914e43 to
1dc3e64
Compare
This library depend on
phpunit/php-code-coverage, this PR allow compatibility with v11 of that library.It also requires a new dependency (which was already included before trough the phpunit/php-code-coverage). I think it’s mandatory because we are using something from this lib.