Optimize UdpSocketAspect (#81)

src/Aspect/UdpSocketAspect.php

@@ -13,39 +13,20 @@
 use Hyperf\Context\Context;
 use Hyperf\Di\Aop\AbstractAspect;
 use Hyperf\Di\Aop\ProceedingJoinPoint;
-use Hyperf\Engine\Socket;
-use Hyperf\Utils\Coroutine;
 use Monolog\Handler\SyslogUdp\UdpSocket;
 
 class UdpSocketAspect extends AbstractAspect
 {
     public array $classes = [
-        UdpSocket::class . '::send',
-        UdpSocket::class . '::close',
+        UdpSocket::class . '::getSocket',
     ];
 
     public function process(ProceedingJoinPoint $proceedingJoinPoint)
     {
-        if (Coroutine::inCoroutine()) {
-            if ($proceedingJoinPoint->methodName == 'close') {
-                return;
-            }
+        [$ip, $port] = (fn () => [$this->ip, $this->port])->call($proceedingJoinPoint->getInstance());
+        (fn () => $this->socket = null)->call($proceedingJoinPoint->getInstance());
+        $key = sprintf('%s_%s_%s_%s', $proceedingJoinPoint->className, 'Socket', $ip, $port);
 
-            /** @var string $chunk */
-            $chunk = $proceedingJoinPoint->arguments['keys']['chunk'] ?? '';
-            [$ip, $port] = (fn () => [$this->ip, $this->port])->call($proceedingJoinPoint->getInstance());
-
-            $key = sprintf('%s_%s_%s_%s', $proceedingJoinPoint->className, 'Socket', $ip, $port);
-            $socket = Context::getOrSet($key, fn () => tap(new Socket(AF_INET, SOCK_DGRAM, SOL_UDP), function (Socket $socket) use ($ip, $port) {
-                $socket->connect($ip, $port, 0.5);
-                defer(fn () => $socket->isClosed() || $socket->close());
-            }));
-
-            $socket->send($chunk);
-
-            return;
-        }
-
-        return $proceedingJoinPoint->process();
+        return Context::getOrSet($key, fn () => $proceedingJoinPoint->process());
     }
 }