Fix tag extraction from resource attributes #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change how the tags ai.cloud.role, ai.cloud.roleInstance, ai.application.ver and ai.internal.sdkVersion are extracted: - Spans no longer extract them from span attributes. They still extract them from resource attributes. And they newly extract them also from instrumentation library attributes. - Events newly extract them from resource and instrumentation library attributes. In addition metrics no longer extract the tag ai.user.authUserId from the enduser.id attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
Change how the tags ai.cloud.role, ai.cloud.roleInstance, ai.application.ver and ai.internal.sdkVersion are extracted:
In addition metrics no longer extract the tag ai.user.authUserId from the enduser.id attribute.