Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal logs #94

Merged
merged 1 commit into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ trace = ["opentelemetry_sdk/trace"]
metrics = ["opentelemetry_sdk/metrics"]
logs = ["opentelemetry_sdk/logs"]
live-metrics = ["trace", "futures-util", "sysinfo"]
internal-logs = ["tracing"]
# Deprecated features: These don't enable anything in
# opentelemetry-application-insights. They only enable features in dependency
# crates.
Expand Down Expand Up @@ -55,6 +56,7 @@ serde_json = "1"
serde_repr = "0.1"
sysinfo = { version = "0.30", optional = true }
thiserror = "2"
tracing = { version = ">=0.1.40", default-features = false, optional = true }

[dev-dependencies]
async-std = { version = "1.13.0", features = ["attributes"] }
Expand Down
1 change: 1 addition & 0 deletions src/quick_pulse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ impl<R: RuntimeChannel> SpanProcessor for QuickPulseManager<R> {
impl<R: RuntimeChannel> Drop for QuickPulseManager<R> {
fn drop(&mut self) {
if let Err(err) = self.shutdown() {
let err: &dyn std::error::Error = &err;
opentelemetry::otel_warn!(name: "ApplicationInsights.LiveMetrics.ShutdownFailed", error = err);
}
}
Expand Down
Loading