Removed screen flicker when entering TUI command screen #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzrehde
force-pushed
the
refactor-terminal-manager
branch
from
0e6ecdb to
a536ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixed #67.
When hiding watchbind's TUI in order for the child/command TUI to execute and draw its own TUI, we previously tore-down watchbind's entire TUI, leading the UI to return to the user's terminal for a split second before drawing the child's/command's TUI. Now, we don't completely unpaint watchbind's TUI and return to the user's terminal, and instead just let the child TUI draw over our (now blank) TUI.
Unfortunately, this "trick" only works when hiding watchbind's TUI and showing the child's TUI, but not when the child's TUI exits and we need to restore/show watchbind's TUI, because we don't control the child's TUI in any way. If we find a solution to the second problem at some point in the future, we'll create a new PR for that.