Skip to content

Commit

Permalink
Switch to pnpm (#151)
Browse files Browse the repository at this point in the history
  • Loading branch information
Panman82 authored Dec 7, 2023
1 parent 53d2068 commit 4acc289
Show file tree
Hide file tree
Showing 8 changed files with 11,586 additions and 35,056 deletions.
36 changes: 13 additions & 23 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,34 +18,28 @@ jobs:
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- name: Install Node
uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: wyvox/action-setup-pnpm@v3
with:
node-version: 16
cache: npm
- name: Install Dependencies
run: npm ci
node-version: 18
- name: Lint
run: npm run lint
run: pnpm lint
- name: Run Tests
run: npm run test:ember
run: pnpm test:ember

floating:
name: "Floating Dependencies"
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: wyvox/action-setup-pnpm@v3
with:
node-version: 16
cache: npm
- name: Install Dependencies
run: npm install --no-shrinkwrap
node-version: 18
args: '--no-lockfile'
- name: Run Tests
run: npm run test:ember
run: pnpm test:ember

try-scenarios:
name: ${{ matrix.try-scenario }}
Expand All @@ -66,13 +60,9 @@ jobs:
- embroider-optimized

steps:
- uses: actions/checkout@v3
- name: Install Node
uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: wyvox/action-setup-pnpm@v3
with:
node-version: 16
cache: npm
- name: Install Dependencies
run: npm ci
node-version: 18
- name: Run Tests
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ commit message for clarification as needed.

* `git clone` this repository (fork if you plan on submitting a PR)
* `cd ember-froala-editor`
* `npm install`
* `pnpm install`


### Running Docs Server
Expand All @@ -31,7 +31,7 @@ commit message for clarification as needed.

### Running Tests

* `npm test` (Runs `ember try:each` to test against multiple Ember versions)
* `pnpm test` (Runs `ember try:each` to test against multiple Ember versions)
* `ember test`
* `ember test --server`
* `ember server` (Visit tests at http://localhost:4200/tests)
Expand Down
2 changes: 1 addition & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Release Process

1. `npm install froala-editor@x.y.z --save` - Updates the editor dependency and lock-file to the specific version
1. `pnpm install froala-editor@x.y.z --save` - Updates the editor dependency and lock-file to the specific version
2. `npm version x.y.z` - Updates the version in `package.json` and tags in git
3. `git push origin master --follow-tags` - Pushes any changes and the new version tag up to Github
4. Update the new tag on the [Github Releases page](https://github.com/froala/ember-froala-editor/releases)
Expand Down
Loading

0 comments on commit 4acc289

Please sign in to comment.