Support arbitrary camera roll #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to use whatever camera orientation is used in GameRenderer#renderWorld. Fetches the InverseViewRotationMatrix used just before world rendering occurs. This enables roll support for mods "Cool Elytra Roll" and "Do a Barrel Roll", and implicitly supports any other mod which changes camera orientation. Move "FlightComputer" instance to be public static in FlightHud class, since both InGameHudMixin and GameRendererMixin need to access the same instance.
|
Bumping as I would love this |
|
love this, when can we merge this PR? |
|
why hasn't this been merged yet? it seems like an epic feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #18. Thanks for fixing support for 1.19.4 @end-user!
Switch to use whatever camera orientation is used in
GameRenderer#renderWorld. Fetches theInverseViewRotationMatrixused just before world rendering occurs and computes roll from that.This enables roll support for mods Cool Elytra Roll and Do a Barrel Roll, and implicitly supports any other mod which changes camera orientation.
Also moves the
FlightComputerinstance to bepublic static final FlightHud#computer, since bothInGameHudMixinandGameRendererMixinneed access and it seems a good place to put the singleton.Short demo clip, showing a full flip with Do a Barrel Roll, here: https://youtu.be/V4x2M-dlUL0