Skip to content
This repository was archived by the owner on Jun 6, 2024. It is now read-only.

Conversation

@davisshaver
Copy link
Contributor

Adds a placeholder script folder and fixes reported issue with compiling from a script.

@TheRightChoyce
Copy link
Contributor

TheRightChoyce commented Jul 18, 2022 via email

@davisshaver
Copy link
Contributor Author

@TheRightChoyce definitely curious to see that! If we end up proceeding with #10, maybe we can just use the Forge JSON output for deployment logging. I assume it has the same info as the bash script (deployer, deployed address, and transaction hash).

On a related note I've been thinking about the JSON structure through #27, specifically this line: https://github.com/holic/web3-scaffold/pull/27/files#diff-faacf75568c5be11b2ca5003bf27d181bbe5fda8995a4183444c5fa0df142678R1

I think we should move the deployedTo value/address to be an environment variable so it's easier to switch between networks without editing code and that would also increase our options w/r/t JSON output management.

@TheRightChoyce
Copy link
Contributor

The default output from the broadcasts are way more verbose. I was going to post an example but its a lot to grok through.

I can block some time tomorrow to do a PR with the deploy.sol script!

@frolic frolic merged commit 2cfb24c into frolic:main Jul 19, 2022
@frolic
Copy link
Owner

frolic commented Jul 19, 2022

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants